Skip to content

Add datafusion-rocksdb crate with basic layout and README #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add datafusion-rocksdb crate with basic layout and README #337

wants to merge 4 commits into from
+81 −4

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Oct 17, 2025 •
edited
Loading

Plan for adding datafusion-rocksdb crate:

  • Explore repository structure and understand existing crate patterns
  • Verify build and test process works
  • Create datafusion-rocksdb crate directory structure
  • Add Cargo.toml for datafusion-rocksdb crate
  • Add README.md for datafusion-rocksdb crate
  • Create basic lib.rs with module structure
  • Verify the new crate builds successfully
  • Run final tests to ensure no regressions
  • Fix CI to use project-specific Rust toolchain version
  • Update Rust toolchain to 1.86.0 for cargo-machete compatibility
Original prompt

Create a branch adding a new crate datafusion-rocksdb. This crate will provide udfs and datafusion extension points. Start with just adding the general layout and readme

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@Copilot Copilot AI changed the title [WIP] Add new crate datafusion-rocksdb with general layout and readme Add datafusion-rocksdb crate with basic layout and README Oct 17, 2025
@Copilot Copilot AI requested a review from matthewmturner October 17, 2025 11:46
Copilot finished work on behalf of matthewmturner October 17, 2025 11:46
matthewmturner

This comment was marked as outdated.

Sign in to view

@matthewmturner
Copy link
Collaborator

@copilot Can you include a fix for CI. Looks like rust toolchain needs to be updated

@Copilot
Copy link
Author

Copilot AI commented Oct 18, 2025 •
edited
Loading

@copilot Can you include a fix for CI. Looks like rust toolchain needs to be updated

Fixed in commit a7520aa - removed the override to stable toolchain so CI now uses the version specified in rust-toolchain.toml (1.85.0).

@copilot Can you include a fix for CI. Looks like rust toolchain needs to be updated

Fixed in commit a7520aa - removed the override to stable toolchain so CI now uses the version specified in rust-toolchain.toml (1.85.0).

Copilot finished work on behalf of matthewmturner October 18, 2025 01:11
@matthewmturner
Copy link
Collaborator

@copilot CI is still failing, fix it. this is one of the errors i saw - we can increase the rust toolchain version if needed

Compiling just v1.43.0
Finished release profile [optimized] target(s) in 1m 06s
Installing /usr/local/cargo/bin/just
Installed package just v1.43.0 (executable just)
error: failed to compile cargo-machete v0.9.1, intermediate artifacts can be found at /tmp/cargo-installTH94TX.
To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.

Caused by:
rustc 1.85.0 is not supported by the following packages:
[email protected] requires rustc 1.86
[email protected] requires rustc 1.86.0
Try re-running cargo install with --locked
Summary Successfully installed just! Failed to install cargo-machete (see error(s) above).
error: some crates failed to install

@Copilot
Copy link
Author

Copilot AI commented Oct 18, 2025

@copilot CI is still failing, fix it. this is one of the errors i saw - we can increase the rust toolchain version if needed

Compiling just v1.43.0
...

Updated Rust toolchain to 1.86.0 in commit to fix cargo-machete installation. The crates [email protected] and [email protected] both require Rust 1.86.

Copilot finished work on behalf of matthewmturner October 18, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewmturner matthewmturner Awaiting requested review from matthewmturner

Assignees

@matthewmturner matthewmturner

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Copilot @matthewmturner